From 10ffeec5694574143ee1cab6b2217bb576edf684 Mon Sep 17 00:00:00 2001 From: Jaime Freire Date: Thu, 13 Apr 2017 19:47:19 +0200 Subject: [PATCH] Closing streams and consuming the entities so pools can reuse connections. Updated failing test. --- src/main/java/net/rcarz/jiraclient/RestClient.java | 10 +++++++++- src/test/java/net/rcarz/jiraclient/SearchTest.java | 2 +- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src/main/java/net/rcarz/jiraclient/RestClient.java b/src/main/java/net/rcarz/jiraclient/RestClient.java index 80fefd7..bd8e4aa 100644 --- a/src/main/java/net/rcarz/jiraclient/RestClient.java +++ b/src/main/java/net/rcarz/jiraclient/RestClient.java @@ -52,6 +52,7 @@ import org.apache.http.entity.mime.MultipartEntity; import org.apache.http.entity.mime.content.ByteArrayBody; import org.apache.http.entity.mime.content.FileBody; import org.apache.http.entity.mime.content.InputStreamBody; +import org.apache.http.util.EntityUtils; /** * A simple REST client that speaks JSON. @@ -153,9 +154,16 @@ public class RestClient { BufferedReader br = new BufferedReader(isr); String line = ""; - while ((line = br.readLine()) != null) + while ((line = br.readLine()) != null) { result.append(line); + } + + isr.close(); + br.close(); + isr=null; + br=null; } + EntityUtils.consumeQuietly(ent); StatusLine sl = resp.getStatusLine(); diff --git a/src/test/java/net/rcarz/jiraclient/SearchTest.java b/src/test/java/net/rcarz/jiraclient/SearchTest.java index 942841c..6f02f8a 100644 --- a/src/test/java/net/rcarz/jiraclient/SearchTest.java +++ b/src/test/java/net/rcarz/jiraclient/SearchTest.java @@ -16,7 +16,7 @@ public class SearchTest { public void testSimpleSearch() throws JiraException { JiraClient jira = new JiraClient("https://jira.atlassian.com/", null); - String key = "JRA-1"; + String key = "JRASERVER-1"; Issue.SearchResult searchResult = jira.searchIssues("key = " + key); assertNotNull(searchResult);